Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavelet Tree Module #4534

Closed
wants to merge 36 commits into from
Closed

Wavelet Tree Module #4534

wants to merge 36 commits into from

Conversation

crafticat
Copy link

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • [x ] I have tested my code.
  • [ x] I have added my solution according to the steps here.
  • [x ] I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • [x ] I have linked this PR to any issues that it closes.

@crafticat crafticat requested a review from dongliuu as a code owner June 19, 2024 13:08
Copy link
Contributor

@SansPapyrus683 SansPapyrus683 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much!

Comment on lines 99 to 101
Let's define:
c[i] = as 1 if index[i] is smaller than mid otherwise 0
prefixB[i] as prefix sum of c[i]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you check how the formatting looks on markdown lol

Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also use language sections around code blocks per usaco.guide standards?

this should also fix your build

crafticat and others added 3 commits June 30, 2024 14:39
Changed time complexity
Added braces
Changed the uniqueID
However, let's explore a different approach that can also be extended to the
second type of query.

### A different way
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to split up the module into this many headers

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would using ### instead of ## also do the job? or would you prefer to erase some of the headers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's best if you erase some of the headers and just split up your ideas into paragraphs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unaddressed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have erased some of the headers. Would you also like me to erase the first type of query and the second type of query header as well?

@stale stale bot removed the stale label Jul 25, 2024
Copy link

stale bot commented Aug 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Aug 3, 2024
@stale stale bot removed stale labels Aug 4, 2024
Copy link

stale bot commented Aug 11, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added stale and removed stale labels Aug 11, 2024
Copy link
Member

@ryanchou-dev ryanchou-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool diagram

"isStarred": false,
"tags": ["Wavelet"],
"solutionMetadata": {
"kind": "none"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crafticat and others added 3 commits August 21, 2024 22:10
Co-authored-by: Ryan Chou <81596991+ryanchou-dev@users.noreply.github.com>
Co-authored-by: Ryan Chou <81596991+ryanchou-dev@users.noreply.github.com>
Copy link

stale bot commented Aug 31, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Aug 31, 2024
Copy link

stale bot commented Sep 7, 2024

Changes requested have not been made. Free free to create a new PR.

@stale stale bot closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants